IME-LONDON
/
LONDON-IOS
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

2.6.1(4)

pull/1/head
InKwon James Kim 5 years ago
parent
b44d7ea7c5
commit
be3466368b
7 changed files with 72 additions and 10 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 8
      GME Remit.xcodeproj/project.pbxproj
  2. 1
      GME Remit/AppDelegate.swift
  3. 8
      GME Remit/Modules/RemittanceModules/OverseasModules/SendMoneyReceipt/User Interface/View/SendMoneyReceiptViewController.swift
  4. 24
      GME Remit/Modules/RemittanceModules/OverseasModules/SendMoneyVerification/User Interface/View/SendMoneyVerificationViewController.swift
  5. 1
      GME Remit/Utilities/Database/GMEDB.swift
  6. 36
      GME Remit/Utilities/StoreReviewHelper.swift
  7. 4
      fastlane/Fastfile

8
GME Remit.xcodeproj/project.pbxproj
View File

@ -110,6 +110,7 @@
730197B422535135001954AB /* kycForm2ViewInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7301978822535135001954AB /* kycForm2ViewInterface.swift */; };
730197B522535135001954AB /* kycForm2.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 7301978922535135001954AB /* kycForm2.storyboard */; };
730197B622535135001954AB /* kycForm2ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7301978A22535135001954AB /* kycForm2ViewController.swift */; };
7303E5732344A1F000472407 /* StoreReviewHelper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7303E5722344A1F000472407 /* StoreReviewHelper.swift */; };
73071AAB2296BE6C008840FD /* HotLine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 73071AAA2296BE6C008840FD /* HotLine.swift */; };
73071AC42296CF9B008840FD /* HotLineModuleInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = 73071AB12296CF9B008840FD /* HotLineModuleInterface.swift */; };
73071AC52296CF9B008840FD /* HotLineService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 73071AB52296CF9B008840FD /* HotLineService.swift */; };
@ -2381,6 +2382,7 @@
7301978822535135001954AB /* kycForm2ViewInterface.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = kycForm2ViewInterface.swift; sourceTree = "<group>"; };
7301978922535135001954AB /* kycForm2.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = kycForm2.storyboard; sourceTree = "<group>"; };
7301978A22535135001954AB /* kycForm2ViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = kycForm2ViewController.swift; sourceTree = "<group>"; };
7303E5722344A1F000472407 /* StoreReviewHelper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoreReviewHelper.swift; sourceTree = "<group>"; };
73071AAA2296BE6C008840FD /* HotLine.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HotLine.swift; sourceTree = "<group>"; };
73071AB12296CF9B008840FD /* HotLineModuleInterface.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = HotLineModuleInterface.swift; sourceTree = "<group>"; };
73071AB52296CF9B008840FD /* HotLineService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = HotLineService.swift; sourceTree = "<group>"; };
@ -11253,6 +11255,7 @@
738F04B02316238600BA5EE7 /* ShadowView.swift */,
731703CB23221EA0005752DE /* SwipeNavigationController.swift */,
73976D212331BFB1003CF5E1 /* BankEnum.swift */,
7303E5722344A1F000472407 /* StoreReviewHelper.swift */,
);
path = Utilities;
sourceTree = "<group>";
@ -14657,6 +14660,7 @@
BE74AFC3227C8FF200F05CE7 /* AddAccountViewController.swift in Sources */,
D9A060DA223F680B00F5D7C4 /* ResendExchangeInteractor.swift in Sources */,
73B4C8C222A5F2440078D495 /* SelectCouponWireframe.swift in Sources */,
7303E5732344A1F000472407 /* StoreReviewHelper.swift in Sources */,
73A6213B2330742C000FFB5B /* DomesticRemitInteractorIO.swift in Sources */,
D950BED121549242008367A1 /* HomeModuleInterface.swift in Sources */,
04E36E1D21AE585200783685 /* PennyTestSubmitInteractor.swift in Sources */,
@ -15202,7 +15206,7 @@
CODE_SIGN_ENTITLEMENTS = "GME Remit.entitlements";
CODE_SIGN_IDENTITY = "iPhone Developer";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 2;
CURRENT_PROJECT_VERSION = 4;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 5QB497ZAGT;
ENABLE_BITCODE = NO;
@ -15237,7 +15241,7 @@
CODE_SIGN_ENTITLEMENTS = "GME Remit.entitlements";
CODE_SIGN_IDENTITY = "iPhone Developer";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 2;
CURRENT_PROJECT_VERSION = 4;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 5QB497ZAGT;
ENABLE_BITCODE = NO;

1
GME Remit/AppDelegate.swift
View File

@ -62,6 +62,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
.app
.remove([.isOpenedTokenRenwalAlert, .isOpenedPopupNotification])
StoreReviewHelper.shared.incrementAppOpenedCount()
return true
}

8
GME Remit/Modules/RemittanceModules/OverseasModules/SendMoneyReceipt/User Interface/View/SendMoneyReceiptViewController.swift
View File

@ -165,6 +165,14 @@ class SendMoneyReceiptViewController: UIViewController {
self.navigationItem.title = ""
}
override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)
if !isFromTransactionHistory {
StoreReviewHelper.shared.checkAndAskForReview()
}
}
// MARK: IBActions
@IBAction func done(_ sender: UIButton) {
if (isFromTransactionHistory) {

24
GME Remit/Modules/RemittanceModules/OverseasModules/SendMoneyVerification/User Interface/View/SendMoneyVerificationViewController.swift
View File

@ -80,8 +80,8 @@ class SendMoneyVerificationViewController: UITableViewController {
let reciepient = self.reciepient,
let password = self.password,
password != ""
else {
return
else {
return
}
model.transactionPassword = password
@ -296,7 +296,11 @@ extension SendMoneyVerificationViewController: BiometricAuthenticationViewContro
}
}
func viewController(_ viewController: BiometricAuthenticationViewController, didFailWithError error: BiometricAuthenticationError, errorMessage: String?) {
func viewController(
_ viewController: BiometricAuthenticationViewController,
didFailWithError error: BiometricAuthenticationError,
errorMessage: String?
) {
print("BiometricAuthenticationWireframe Error: \(errorMessage ?? "")")
viewController.dismiss(animated: true){
@ -309,7 +313,11 @@ extension SendMoneyVerificationViewController: BiometricAuthenticationViewContro
switch type {
case "autodebit":
SendMoneyCodeWireframe().open(requestmodel: self.requestModel, completion: self.otpEntered, source: self)
SendMoneyCodeWireframe().open(
requestmodel: self.requestModel,
completion: self.otpEntered,
source: self
)
case "wallet":
self.showSecureKeypad()
default:
@ -323,15 +331,15 @@ extension SendMoneyVerificationViewController: BiometricAuthenticationViewContro
}
}
func doSelectLocalAuthenticationPolicy(_ viewController: BiometricAuthenticationViewController) -> BiometricAuthenticationPolicy{
func doSelectLocalAuthenticationPolicy(
_ viewController: BiometricAuthenticationViewController
) -> BiometricAuthenticationPolicy{
return .deviceOwnerAuthenticationWithBiometrics
}
}
extension SendMoneyVerificationViewController: SecureKeypadDelegate {
func didComplete(_ encryptedString: String, garbagePassword: String, length: Int) {
func didComplete(_ encryptedString: String, length: Int) {
self.password = encryptedString
}
self.password = encryptedString
}
}

1
GME Remit/Utilities/Database/GMEDB.swift
View File

@ -76,6 +76,7 @@ class GMEDB {
case isOpenedTokenRenwalAlert
case isOpenedPopupNotification
case openCount
}
let user = UserDefaultsWrapper<UserKeys>()

36
GME Remit/Utilities/StoreReviewHelper.swift
View File

@ -0,0 +1,36 @@
//
// StoreReviewHelper.swift
// GME Remit
//
// Created by InKwon James Kim on 02/10/2019.
// Copyright © 2019 Gobal Money Express Co. Ltd. All rights reserved.
//
import Foundation
import StoreKit
class StoreReviewHelper {
static let shared = StoreReviewHelper()
func incrementAppOpenedCount() {
var appOpenCount = GMEDB.shared.app.integer(.openCount)
appOpenCount += 1
GMEDB.shared.app.set(appOpenCount, .openCount)
}
func checkAndAskForReview() {
requestReview()
// let openCount = GMEDB.shared.app.integer(.openCount)
//
// switch openCount {
// case 3, 5: StoreReviewHelper().requestReview()
// case _ where openCount % 100 == 0 : StoreReviewHelper().requestReview()
// default: print("App run count is : \(openCount)")
// }
}
private func requestReview() {
SKStoreReviewController.requestReview()
}
}

4
fastlane/Fastfile
View File

@ -18,6 +18,10 @@ default_platform(:ios)
platform :ios do
desc "Push a new beta build to TestFlight"
lane :beta do
# increment_build_number(
# build_number: app_store_build_number + 1,
# xcodeproj: "Example.xcodeproj"
# )
build_app(workspace: "GME Remit.xcworkspace", scheme: "GME Remit")
upload_to_testflight
end

Write Preview
Loading…
Cancel
Save